Conversation
That class doesn't come from core - there are no |
|
They must come directly from |
|
@kmcfaul Can you do post the Patternfly document to surge and include it in this PR so design can see the updates. |
|
Here is the surge - https://windy-clocks-47747.surge.sh/ |
nicolethoen
left a comment
There was a problem hiding this comment.
From what I can tell, the console is behaving the same way in your preview that it does on patternfly.org right now.
I know react-console has some styles which are defined and live in @patternfly/react-styles, so we should open a follow up issue for this PR to make sure those are all using the tokens correctly (and then an additional follow up here to consume the latest react-styles version).
But i don't see anything here IMO that would block this from merging as an alpha :)
|
🎉 This PR is included in version 6.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #46.
pf-v6-c-console__xtermdoesn't seem to exist, did we have a v5 for this or was it always just a placeholder? @mcoker)