feat(CloseButton): Added close button from OpenShift.#88
Merged
dlabaj merged 11 commits intopatternfly:mainfrom Jan 31, 2024
Merged
feat(CloseButton): Added close button from OpenShift.#88dlabaj merged 11 commits intopatternfly:mainfrom
dlabaj merged 11 commits intopatternfly:mainfrom
Conversation
Contributor
In the current state you still may be able to overwrite |
fhlavac
reviewed
Jan 15, 2024
...dule/patternfly-docs/content/extensions/component-groups/examples/CloseButton/CloseButton.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Jan 15, 2024
...ternfly-docs/content/extensions/component-groups/examples/CloseButton/CloseButtonExample.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Jan 15, 2024
fhlavac
reviewed
Jan 15, 2024
fhlavac
reviewed
Jan 15, 2024
Contributor
|
Just some nitpicking. |
nicolethoen
reviewed
Jan 30, 2024
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
only one note from me
...dule/patternfly-docs/content/extensions/component-groups/examples/CloseButton/CloseButton.md
Outdated
Show resolved
Hide resolved
Contributor
|
@dlabaj would you have time to take a look today so we can get this one in? Thank you 🙂 |
…roups/examples/CloseButton/CloseButton.md Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
…roups/examples/CloseButton/CloseButtonExample.tsx Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
|
🎉 This PR is included in version 5.1.0-prerelease.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
RHCLOUD-30381
Added the close button from OpenShift.