feat(skeletonTable): Added skeleton table component.#56
Merged
fhlavac merged 13 commits intopatternfly:mainfrom Oct 24, 2023
Merged
feat(skeletonTable): Added skeleton table component.#56fhlavac merged 13 commits intopatternfly:mainfrom
fhlavac merged 13 commits intopatternfly:mainfrom
Conversation
This was
linked to
issues
Oct 12, 2023
Updated with the latest table code. updated with composible table. Updated to remove scss file.
dlabaj
changed the title
edonehoo
reviewed
Oct 19, 2023
...ges/module/patternfly-docs/content/extensions/component-groups/examples/Skeleton/Skeleton.md
Outdated
Show resolved
Hide resolved
...ges/module/patternfly-docs/content/extensions/component-groups/examples/Skeleton/Skeleton.md
Outdated
Show resolved
Hide resolved
...ges/module/patternfly-docs/content/extensions/component-groups/examples/Skeleton/Skeleton.md
Outdated
Show resolved
Hide resolved
…roups/examples/Skeleton/Skeleton.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…roups/examples/Skeleton/Skeleton.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…roups/examples/Skeleton/Skeleton.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
fhlavac
reviewed
Oct 23, 2023
...ges/module/patternfly-docs/content/extensions/component-groups/examples/Skeleton/Skeleton.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Oct 23, 2023
...ges/module/patternfly-docs/content/extensions/component-groups/examples/Skeleton/Skeleton.md
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Oct 23, 2023
...y-docs/content/extensions/component-groups/examples/Skeleton/SkeletonTableLoadingExample.tsx
Outdated
Show resolved
Hide resolved
fhlavac
reviewed
Oct 23, 2023
|
|
||
| const useStyles = createUseStyles({ | ||
| skeleton: { | ||
| '&.ins-m-dark': { |
Contributor
There was a problem hiding this comment.
this is a dark mode support specific to Red Hat insights, we could probably at least adjust the className to match our rules
Collaborator
There was a problem hiding this comment.
I think it should be straight-up removed. Pf has its own dark mode support.
Collaborator
Author
There was a problem hiding this comment.
Was thinking that as well. Done it's removed.
Contributor
|
@dlabaj just little comments. Looks really good! Thank you 🎉 |
…roups/examples/Skeleton/Skeleton.md Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
…roups/examples/Skeleton/Skeleton.md Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
…roups/examples/Skeleton/SkeletonTableLoadingExample.tsx Co-authored-by: Filip Hlavac <50696716+fhlavac@users.noreply.github.com>
fhlavac
approved these changes
Oct 24, 2023
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added skeleton table using composable table.
https://skeleton-table.surge.sh