Merged
Conversation
Contributor
|
@aferd it looks really good, just two thoughts on props that may allow more customizability in case it's needed Can you please also improve the commit messages to trigger the semantic release when merged? Thank you |
fhlavac
reviewed
Oct 29, 2024
aferd
changed the title
karelhala
reviewed
Oct 30, 2024
Collaborator
karelhala
left a comment
karelhala
left a comment
There was a problem hiding this comment.
Looking good! Just one minor question.
fhlavac
reviewed
Oct 31, 2024
fhlavac
approved these changes
Oct 31, 2024
fhlavac
reviewed
Oct 31, 2024
|
🎉 This PR is included in version 6.1.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RHCLOUD-33366 Add Maintenance component