Merged
Conversation
fhlavac
reviewed
Jul 15, 2024
Comment on lines
18
to
19
| cy.get('[class="pf-v5-c-expandable-section__toggle"]').click(); | ||
| cy.get('[class="pf-v5-c-expandable-section__content"]').should('contain.text', 'Error: but a welcome one'); |
Contributor
There was a problem hiding this comment.
@InsaneZein can you please use ouia ID's hare rather than classNames?
fhlavac
reviewed
Jul 15, 2024
Comment on lines
159
to
161
| cy.get('[class="pf-v5-c-menu-toggle pf-m-plain"').should('exist'); | ||
| cy.get('[class="pf-v5-c-menu-toggle pf-m-plain"').click(); | ||
| cy.get('[class="pf-v5-c-menu"').should('be.visible'); |
Contributor
There was a problem hiding this comment.
it would be good to get rid of classNames here as well
Contributor
There was a problem hiding this comment.
also, we don't seem to be testing the dividers are present
Contributor
|
Just minor comments, overall, it looks great! |
Collaborator
Author
|
@fhlavac I've added ouia ids where possible |
fhlavac
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for RHCLOUD-32488