WIP: feat(cypress): Added cypress and integration test for the close button.#118
Merged
dlabaj merged 4 commits intopatternfly:mainfrom Mar 5, 2024
Merged
WIP: feat(cypress): Added cypress and integration test for the close button.#118dlabaj merged 4 commits intopatternfly:mainfrom
dlabaj merged 4 commits intopatternfly:mainfrom
Conversation
dlabaj
requested review from
Hyperkid123,
InsaneZein,
fhlavac,
jessiehuff and
wise-king-sullyman
dlabaj
commented
Mar 5, 2024
| @@ -0,0 +1,73 @@ | |||
| { | |||
Collaborator
Author
There was a problem hiding this comment.
Note this extra tsconfig file is needed for cypress testing.
fhlavac
approved these changes
Mar 5, 2024
jessiehuff
approved these changes
Mar 5, 2024
|
🎉 This PR is included in version 5.1.0-prerelease.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added cypress testing to component groups, and I created the close button test to show how to write a cypress test. Need to setup scripts and github actions then i will remove the WIP label.
Resolves issue #117
Image of github actions passing with cypress tests.