Add OpenShift MultiContentCard (GettingStarted)#112
Conversation
| </Card>, | ||
| <Card isFullHeight isPlain key="card-2"> | ||
| <CardBody className="pf-v5-u-display-flex pf-v5-u-pt-3xl-on-md"> | ||
| <TextContent className="pf-v5-u-display-flex pf-v5-u-flex-direction-column pf-v5-u-align-self-stretch"> |
There was a problem hiding this comment.
I think all theses utility classes can be replaced by a Flex layout with modifiers for direction={{ default: 'column' }} and use the various spacing features :https://www.patternfly.org/layouts/flex#spacing to match this demo: https://www.patternfly.org/patterns/dashboard/html-demos/basic/
| } | ||
| } | ||
| }, | ||
| multiContentCardBorder: { |
There was a problem hiding this comment.
Let's use Divider components rather than borders
|
Thanks @nicolethoen for taking a look, working on the updates.. |
| </TextContent> | ||
| </CardHeader> | ||
| <CardBody className="pf-v5-u-display-flex"> | ||
| <TextContent className="pf-v5-u-display-flex pf-v5-u-flex-direction-column pf-v5-u-align-self-stretch"> |
There was a problem hiding this comment.
I believe a Flex layout could be used in place of all these utility classes
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
some opportunity to use Flex in the example code, but overall looks good to me!
|
🎉 This PR is included in version 5.1.0-prerelease.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
closes #97
RHCLOUD-30683
Added a new MultiContentCard component to replace OpenShift and HCC implementations.