-
Notifications
You must be signed in to change notification settings - Fork 34
feat(ResponseActions): added opt-in for hiding actions until interaction #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| // We want to append the tooltip inline so that hovering the tooltip keeps the actions container visible | ||
| // when showActionsOnInteraction is true. Otherwise hovering the tooltip causes the actions container | ||
| // to disappear but the tooltip will remain visible. | ||
| const getTooltipContainer = (): HTMLElement => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to call this out: if we want to for now we could remove this logic and just deal with the visual oddity that occurs, as Gemini has this exact behavior when you try hovering a message action and then hover over the action tooltip (action isn't visible, but the tooltip remains)
|
Preview: https://chatbot-pr-chatbot-806.surge.sh A11y report: https://chatbot-pr-chatbot-806-a11y.surge.sh |
|
|
||
| &:hover .pf-m-visible-interaction, | ||
| .pf-m-visible-interaction:focus-within { | ||
| opacity: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want any sort of transition token to allow this to fade in/out or anything like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaylachumley wdyt?
closes #792
Updated the message actions example to include a Message that has this feature