-
Notifications
You must be signed in to change notification settings - Fork 34
fix(Message): Add block quotes and headings #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://chatbot-pr-chatbot-420.surge.sh A11y report: https://chatbot-pr-chatbot-420-a11y.surge.sh |
Added block quote and heading styling; also fixed small rendering bug with inline code styles.
e78d38e to
5005656
Compare
kaylachumley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments!
|
All set - deprecated those aliased styles and adjusted the one that differed from Kayla's spec. |
edonehoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little bit of fiddling. I like the change to radio controls 🎉
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/UserMessage.tsx
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/UserMessage.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/UserMessage.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Outdated
Show resolved
Hide resolved
0e33b1a to
d888f4d
Compare
Co-authored-by: Erin Donehoo <[email protected]>
d888f4d to
25f2db7
Compare
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/UserMessage.tsx
Outdated
Show resolved
Hide resolved
…mples/Messages/BotMessage.tsx Co-authored-by: Erin Donehoo <[email protected]>
03825ff to
05582f5
Compare
|
They're not new, but they're real issues. I can stick var(--pf-t--global--background--color--secondary--default) on the code block (it'll make it darker), but I'm not sure what color we'd want for inline code. @kaylachumley - would you be able to weigh in here? |
|
@rebeccaalpert @edonehoo Weighing in about the above conversation! For the codeblock messages: It looks we need to be using pf-t--global--background--color--inverse--default for the background and the text color should be pf-t--global--text--color--inverse. Also another thing I just noticed is that the icon button is on the right side of the block in the figma designs and there is also a title line that displays the code type. Would it be possible to right align the icon button and add the title line? I can also see a case to make title line optional and if that's the case, then I would keep the copy icon button on the left! For the inline code highlight on the user message: I'm not entirely sure yet. I was going to suggest --pf-t--global--background--color--tertiary--default but I am not sure how that will turn out in dark mode. I tried testing that with the inspect but it got really hacky. Let me get some insight from lucia on that |
587f772 to
370cf82
Compare
|
One issue I do want to raise is that we have no control over the code editor background itself, so it will look "interesting" with this color change:
PatternFly uses a third-party Monaco theme, as documented here: #149. It's a somewhat large lift, so we've been putting if off. Do you want to back this change out for now? Let me know. |
370cf82 to
f5eb569
Compare
|
@rebeccaalpert Is it possible to get the code editor to look like the figma designs with the background extended around the button and title text? The tokens applied to the icon copy button was based off it sitting on top of that inverse code background, so it would need adjusted if we cant mimic the original layout |
|
Talked to Kayla. I was confused and was giving you the wrong facts here. We may be able to adjust the code block here a bit more, but we have less control over the other code editor (in the code modal one). This change would bring them out of alignment. It seems that these are 1 component in Figma and two separate PatternFly components in the code. This is out of scope for this PR - we're going to back out the code message change here and address in #424 as time allows. I asked Kayla to take a look at #424 and make sure it correctly covers what we want to do here so we don't lose it. I will keep the bug fix and the inline code style changes - just backing out the color change for the block code message. |
440b405 to
3e190fa
Compare
nicolethoen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
|
🎉 This PR is included in version 2.2.0-prerelease.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added block quote and heading styling. Also fixed small rendering bug with inline code styles, and fixed bug where code block language was not being displayed. Co-authored-by: Erin Donehoo <[email protected]>








Added block quote and heading styling; also fixed small rendering bug with inline code styles.
This affects Bot and User messages: