Skip to content

Conversation

@david-moldenhauer
Copy link
Contributor

Closes #

Summary of changes:
Adds support for pseudo patterns for example button~variant.json

@coreylafferty
Copy link

Would (or could) this work with YAML files as well as JSON?

@david-moldenhauer
Copy link
Contributor Author

david-moldenhauer commented May 23, 2019

Would (or could) this work with YAML files as well as JSON?

it should work on YAML as well as JSON

@stale
Copy link

stale bot commented Jul 23, 2019

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@sghoweri
Copy link
Contributor

Bump - want to make sure this doesn’t get lost

@bmuenzenmeyer bmuenzenmeyer added the pinned 📌 Don't let stalebot clean this up label Aug 23, 2019
@zhawkins
Copy link
Contributor

Which template engine has this been tested with? Without this patch it looks like handlebars is working correctly. 🤔 With the patch twig php doesn't seem to be working but that could be a different issue.

@zhawkins
Copy link
Contributor

I've opened a separate issue for twig php pseudo patterns. #1045

@sghoweri sghoweri self-requested a review October 14, 2019 12:14
@sghoweri sghoweri added the hacktoberfest 🌾 https://hacktoberfest.digitalocean.com label Oct 14, 2019
Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm if this PR is still necessary based on the latest work that's up on dev?

Without this PR, I can confirm that Twig and Handlebar psuedo patterns both appear to be working as expected.

In fact, if I enable the changes from this PR it actually seems to break the Twig psuedo pattern logic that was just merged in, so I'd love to confirm if we still need this update (and if so, we can troubleshoot accordingly) or if we can close this out.

LMK!

@zhawkins
Copy link
Contributor

I believe #1046 is a replacement for this PR.

Since that resolves the variant issues with psuedo patterns I think this can be closed.

@sghoweri
Copy link
Contributor

I believe #1046 is a replacement for this PR.

Since that resolves the variant issues with psuedo patterns I think this can be closed.

Sounds good! Thanks again for your help @zhawkins!

@sghoweri sghoweri closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest 🌾 https://hacktoberfest.digitalocean.com pinned 📌 Don't let stalebot clean this up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants