-
Notifications
You must be signed in to change notification settings - Fork 401
Add support for pseudo patterns for example button~variant.json #1017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pseudo patterns for example button~variant.json #1017
Conversation
|
Would (or could) this work with YAML files as well as JSON? |
it should work on YAML as well as JSON |
|
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
|
Bump - want to make sure this doesn’t get lost |
|
Which template engine has this been tested with? Without this patch it looks like handlebars is working correctly. 🤔 With the patch twig php doesn't seem to be working but that could be a different issue. |
|
I've opened a separate issue for twig php pseudo patterns. #1045 |
sghoweri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we confirm if this PR is still necessary based on the latest work that's up on dev?
Without this PR, I can confirm that Twig and Handlebar psuedo patterns both appear to be working as expected.
In fact, if I enable the changes from this PR it actually seems to break the Twig psuedo pattern logic that was just merged in, so I'd love to confirm if we still need this update (and if so, we can troubleshoot accordingly) or if we can close this out.
LMK!
|
I believe #1046 is a replacement for this PR. Since that resolves the variant issues with psuedo patterns I think this can be closed. |
Closes #
Summary of changes:
Adds support for pseudo patterns for example button~variant.json