This repository was archived by the owner on Apr 22, 2021. It is now read-only.
Corrects environment and failing tests#65
Merged
flippyhead merged 5 commits intopathable:masterfrom Jul 24, 2015
Merged
Conversation
Corrects "Collections handle duplicates correctly" test Updates deprecated browserify version
Contributor
|
Nice 👍 |
This was referenced Jul 12, 2015
Closed
…ion (n-1 and n-n)
flippyhead
added a commit
that referenced
this pull request
Jul 24, 2015
Corrects environment and failing tests
Contributor
|
Fantastic thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects "Respect idAttribute" and "Remove duplicate models" tests
Corrects "Collections handle duplicates correctly" test
Updates deprecated browserify version
New versions of Backbone take up changes that affects to Supermodel library.
Collections are no longer going to merge attributes from duplicate models inside a collection. Instead, and for fixing the "Collections handle duplicates correctly" test, you have to pass an option specifically ({merge: true}).
Regarding "Respect idAttribute" test, Collections now require the model constructor passed as a parameter to take advantage of the specific model context, for example, to be able to get a model from a collection by the custom idAttribute definition. Thus, the collection associated for each particular model constructor (all) must be defined in such a way.
Finally, the "Remove duplicate models" test got failed in the last Backbone version (1.2.1) as a regression bug was created (jashkenas/backbone#3693). For the moment, the Backbone version defined at the package has been limited by versions prior to 1.2.1 version, until it is fixed.