Skip to content
This repository was archived by the owner on Apr 22, 2021. It is now read-only.

Comments

Corrects environment and failing tests#65

Merged
flippyhead merged 5 commits intopathable:masterfrom
nachocodoner:fixTest
Jul 24, 2015
Merged

Corrects environment and failing tests#65
flippyhead merged 5 commits intopathable:masterfrom
nachocodoner:fixTest

Conversation

@nachocodoner
Copy link
Contributor

Corrects "Respect idAttribute" and "Remove duplicate models" tests
Corrects "Collections handle duplicates correctly" test
Updates deprecated browserify version

New versions of Backbone take up changes that affects to Supermodel library.

Collections are no longer going to merge attributes from duplicate models inside a collection. Instead, and for fixing the "Collections handle duplicates correctly" test, you have to pass an option specifically ({merge: true}).

Regarding "Respect idAttribute" test, Collections now require the model constructor passed as a parameter to take advantage of the specific model context, for example, to be able to get a model from a collection by the custom idAttribute definition. Thus, the collection associated for each particular model constructor (all) must be defined in such a way.

Finally, the "Remove duplicate models" test got failed in the last Backbone version (1.2.1) as a regression bug was created (jashkenas/backbone#3693). For the moment, the Backbone version defined at the package has been limited by versions prior to 1.2.1 version, until it is fixed.

@TheBox193
Copy link
Contributor

Nice 👍

This was referenced Jul 12, 2015
flippyhead added a commit that referenced this pull request Jul 24, 2015
Corrects environment and failing tests
@flippyhead flippyhead merged commit 1804dab into pathable:master Jul 24, 2015
@flippyhead
Copy link
Contributor

Fantastic thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants