This repository was archived by the owner on Apr 22, 2021. It is now read-only.
toJSON include related models.#61
Merged
flippyhead merged 1 commit intopathable:masterfrom Jul 24, 2015
Merged
Conversation
Template frameworks like Handlebars use the results of the `toJSON` for the data that is available to them to use. I've found it convenient to include related models in the `toJSON` response almost similar to the Eager Loading idea ORMs have. This is helpful when rendering say a post, and want to include the author or react based on the type of author for instance.
In the model we just set `withJSON` with the models to be included:
var Post = Supermodel.Model.extend({
urlRoot:App.apiURL+'posts',
withJSON: ['user', 'image']
});
The toJSON function will both test if the relationship type exists, and if this model has one related. If one exists- its toJSON is called and the result is assigned to the name of the relationship.
Their might be a better option name than withJSON. Feel free to test, I thought this might be nice.
flippyhead
added a commit
that referenced
this pull request
Jul 24, 2015
toJSON include related models.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template frameworks like Handlebars use the results of the
toJSONfor the data that is available to them to use. I've found it convenient to include related models in thetoJSONresponse almost similar to the Eager Loading idea ORMs have. This is helpful when rendering say a post, and want to include the author or react based on the type of author for instance.In the model we just set
withJSONwith the models to be included:The toJSON function will both test if the relationship type exists, and if this model has one related. If one exists- its toJSON is called and the result is assigned to the name of the relationship.
Their might be a better option name than withJSON. Feel free to test, I thought this might be nice.