Added support for terminating a spawned worker if a timeout is reached#207
Merged
mathiasrw merged 2 commits intoparallel-js:masterfrom Oct 6, 2020
Merged
Added support for terminating a spawned worker if a timeout is reached#207mathiasrw merged 2 commits intoparallel-js:masterfrom
mathiasrw merged 2 commits intoparallel-js:masterfrom
Conversation
mathiasrw
requested changes
Oct 5, 2020
Member
mathiasrw
left a comment
mathiasrw
left a comment
There was a problem hiding this comment.
Epic. Please also add a description of the new option in the readme file too.
Contributor
Author
|
Thanks! I've added an update to the documentation. However, is it possible that the new timeout option will overwrite an environment variable that could be set in the Parallel constructor? |
mathiasrw
approved these changes
Oct 6, 2020
Member
|
Thank you! |
Member
|
released as part of v1.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found this lib because I was searching for a way to easily spawn a worker, but also be able to terminate it if a timeout is reached. The use case is that I want to time limit execution for certain operations.
I don't have any experience with the test frameworks in this lib, but if my pull request looks promising, I'm happy to learn and create a test spec. But only if you think this extra feature even belongs in parallel.js?