[FSSDK-10763] Implement UPS request batching for decideForKeys#440
Merged
FarhanAnjum-opti merged 29 commits intomasterfrom Nov 27, 2024
Merged
[FSSDK-10763] Implement UPS request batching for decideForKeys#440FarhanAnjum-opti merged 29 commits intomasterfrom
FarhanAnjum-opti merged 29 commits intomasterfrom
Conversation
…file` in decision logic. 🛠️ optimizely/user_profile.py -> Improved user profile loading with missing key checks. 🛠️ tests/test_decision_service.py -> Updated tests to include user profile tracker.
🛠️ tests/test_decision_service.py -> Updated experiment bucket map call. 🛠️ tests/test_decision_service.py -> Introduced user_profile_tracker usage. 🛠️ tests/test_decision_service.py -> Modified method calls with user_profile_tracker.
tests/test_decision_service.py -> Added user profile tracker object
tests/test_decision_service.py -> Fixed tests
Mat001
requested changes
Nov 20, 2024
Contributor
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
Looks great! Just please cleanup old commented out pieces. Then we'll merge once done :)
raju-opti
requested changes
Nov 21, 2024
optimizely/optimizely.py -> Added loading and saving profile logic
optimizely/user_profile.py -> Testing user profile update logic
optimizely/user_profile.py -> Removed unused import statement
optimizely/user_profile.py -> Fixed handling of reasons list optimizely/user_profile.py -> Improved profile retrieval error logging tests/test_decision_service.py -> Updated mock checks to simplify tests tests/test_user_profile.py -> Added tests for user profile handling tests/test_optimizely.py -> New test for variation lookup and save
Mat001
approved these changes
Nov 27, 2024
Contributor
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
I think it looks ok to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues