feat: add odp event manager#403
Merged
andrewleap-optimizely merged 18 commits intomasterfrom Sep 2, 2022
Merged
Conversation
Mat001
reviewed
Aug 24, 2022
jaeopt
requested changes
Aug 25, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good. A few changes suggested.
Also let's discuss how we should handle events with odpConfig lifecycle.
Mat001
approved these changes
Aug 29, 2022
Contributor
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
Looks good to me. Pretty complex PR.
Made a comment about the name CopyingMock class.
jaeopt
requested changes
Aug 30, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks great! A few changes suggested.
jaeopt
requested changes
Aug 30, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
All changes look good.
I found one more case to discuss to clarify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OdpEventManager provides internal services for sending ODP events to the ODP server.
Test plan
Ticket
OASIS-8442