feat: add odp rest api manager

[Mat001]

Summary

• Added rest api code for odp. Sending events to ODP platform.
• added class OdpEvent
• added a helper function for creating and mocking a fake server response
• added unit tests
• fixed typo in enums
• minor fixes to odp graphql manager tests
• See acceptance criteria in the ticket below.

Test plan

• unit tests
• FSC tests

Issues

• OASIS-8447 Python - add ODP RestApi interface

[andrewleap-optimizely]

Looks good so far! I like that you reused the mock response, that's a good idea. Just a couple changes

[jaeopt]

Looks good. A couple of small changes suggested.

[Mat001]

@jaeopt @andrewleap-optimizely I hope exception for invalid URL is handled ok. Request.Exception's class InvalidURL is not comprehensive at all. For example it doesn't catch https://api.zaius..com or XXhttps://api.zaius.com. For cases like these two I had to add other exceptions. If better idea how to guard against an invalid url lmk

I'm not super clear how swift does it, it seems it checks for exactly that url string?
guard let url = URL(string: "\(apiHost)/v3/events") else {
let canRetry = false
completionHandler(.odpEventFailed("Invalid url", canRetry))
return
}

[andrewleap-optimizely]

I'm not super clear how swift does it, it seems it checks for exactly that url string? guard let url = URL(string: "\(apiHost)/v3/events") else { let canRetry = false completionHandler(.odpEventFailed("Invalid url", canRetry)) return }

We can accomplish something similar using urllib.parse.urlparse

[jaeopt]

@jaeopt @andrewleap-optimizely I hope exception for invalid URL is handled ok. Request.Exception's class InvalidURL is not comprehensive at all. For example it doesn't catch https://api.zaius..com or XXhttps://api.zaius.com. For cases like these two I had to add other exceptions. If better idea how to guard against an invalid url lmk

I'm not super clear how swift does it, it seems it checks for exactly that url string? guard let url = URL(string: "\(apiHost)/v3/events") else { let canRetry = false completionHandler(.odpEventFailed("Invalid url", canRetry)) return }

@Mat001 I understand that RequestException will catch these all.
I don't think we need this fine level of error handling, since this is not expected to happen (apiHost we control).
Can be cleaned up if needed. Swift checks url only for lang level requirement for optional filtering.

[Mat001]

@jaeopt @andrewleap-optimizely ok. I refactored. I got rid of the specific URL parsing exceptions and made it such that generic RequestEception catches invalid URL errors (may not include urlparse errors), but it guard against quite a few. And since we control the URL I wouldn't worry about this one, if that's ok

[jaeopt]

LGTM with a clarification

[jaeopt]

I think so, but can you confirm that this catches all other exceptions?

[Mat001]

@jaeopt yes, confirm. We use the same exception handling in event_dispatcher and fetch_datafile:
https://github.com/optimizely/python-sdk/blob/master/optimizely/event_dispatcher.py#L56
https://github.com/optimizely/python-sdk/blob/master/optimizely/config_manager.py#L367

It'll catch all these: https://requests.readthedocs.io/en/latest/_modules/requests/exceptions/

[andrewleap-optimizely]

lgtm