Skip to content

feat: BatchEventProcessor as Default Event Processor#378

Merged
msohailhussain merged 8 commits intomasterfrom
uzair/default_batch_event_processor
Jun 28, 2022
Merged

feat: BatchEventProcessor as Default Event Processor#378
msohailhussain merged 8 commits intomasterfrom
uzair/default_batch_event_processor

Conversation

@ozayr-zaviar
Copy link
Contributor

Summary

  • ForwardingEventProcessor sends calls in a synchronous manner so to reduce the time it is replaced with BatchEventProcessor which sends calls in an asynchronous manner.

Test plan

  • All unit tests and FSC tests should pass.

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review June 15, 2022 21:13
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner June 15, 2022 21:13
@andrewleap-optimizely
Copy link
Contributor

@msohailhussain made some small changes to fix the broken tests and make the api more intuitive.

Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit 6b590eb into master Jun 28, 2022
@msohailhussain msohailhussain deleted the uzair/default_batch_event_processor branch June 28, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants