feat: Semantic Versioning#293
Merged
thomaszurkan-optimizely merged 39 commits intooptimizely:masterfrom Sep 17, 2020
Merged
Conversation
Contributor
|
Need to add FSC |
thomaszurkan-optimizely
approved these changes
Aug 20, 2020
Contributor
thomaszurkan-optimizely
left a comment
thomaszurkan-optimizely
left a comment
There was a problem hiding this comment.
LGTM, needs to pass FSC first.
thomaszurkan-optimizely
suggested changes
Aug 20, 2020
Contributor
thomaszurkan-optimizely
left a comment
thomaszurkan-optimizely
left a comment
There was a problem hiding this comment.
Actually we forgot le and ge (less than or equal and greater than or equal
aliabbasrizvi
suggested changes
Aug 20, 2020
optimizely/helpers/condition.py
Outdated
| def semver_equal_evaluator(self, index): | ||
| """ Evaluate the given semantic version equal match target version for the user version. | ||
|
|
||
| Args: |
Contributor
There was a problem hiding this comment.
nit. Indentation is off. This needs to align with the quotes above.
|
|
||
| self.assertRaises(Exception) | ||
|
|
||
| def test_evalduate__returns_exception__when_user_provided_version_is_invalid9(self): |
Contributor
There was a problem hiding this comment.
Typo in evaluate through the file
Contributor
|
Taking a closer look at evaluation. But some typos as well as docstrings need to have aligned strings. |
optimizely/helpers/condition.py
Outdated
Comment on lines
333
to
349
| if self.has_white_space(target): | ||
| raise Exception(Errors.INVALID_ATTRIBUTE_FORMAT) | ||
|
|
||
| if self.is_pre_release(target): | ||
| target_parts = target.split(SemverType.IS_PRE_RELEASE) | ||
| elif self.is_build(target): | ||
| target_parts = target.split(SemverType.IS_BUILD) | ||
|
|
||
| if target_parts: | ||
| if len(target_parts) < 1: | ||
| raise Exception(Errors.INVALID_ATTRIBUTE_FORMAT) | ||
| target_prefix = str(target_parts[0]) | ||
| target_suffix = target_parts[1:] | ||
|
|
||
| dot_count = target_prefix.count(".") | ||
| if dot_count > 2: | ||
| raise Exception(Errors.INVALID_ATTRIBUTE_FORMAT) |
Contributor
There was a problem hiding this comment.
Can you add comments over each of these about what is being checked in the if condition?
Comment on lines
163
to
165
| IS_PRE_RELEASE = '-' | ||
| HAS_WHITE_SPACE = " " | ||
| IS_BUILD = '+' |
Contributor
There was a problem hiding this comment.
We should use single quotes for all strings.
optimizely-codereview-bot
requested review from
aliabbasrizvi and
thomaszurkan-optimizely
optimizely-codereview-bot
added
🤖 8 hrs
🤖 12 hrs
🤖 16 hrs
🤖 20 hrs
and removed
🤖 4 hrs
🤖 8 hrs
🤖 12 hrs
🤖 16 hrs
labels
aliabbasrizvi
approved these changes
Sep 14, 2020
| self.assertIsNone(evaluator.evaluate(0)) | ||
|
|
||
| def test_greater_than_int__returns_true__when_user_value_greater_than_condition_value(self,): | ||
| def test_greater_than_int__returns_true__when_user_value_greater_than_condition_value(self, ): |
Contributor
There was a problem hiding this comment.
Why the , and this can simply be (self) right?
added 3 commits
September 14, 2020 19:05
thomaszurkan-optimizely
approved these changes
Sep 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for semantic versioning in audience evaluation.
Test plan
Added unit tests