[FSSDK-9630] Fix: Code examples

[localheinz]

Summary

• fixes code examples

Test plan

n/a

Issues

n/a

[FSSDK-9630]

[coveralls]

coverage: 97.333%. remained the same when pulling c1e0803 on localheinz:fix/example into 04f5c20 on optimizely:master.

[coveralls]

coverage: 97.333%. remained the same when pulling c1e0803 on localheinz:fix/example into 04f5c20 on optimizely:master.

[mikechu-optimizely]

Hey @localheinz , I'm looking to roll up your (kindly) provided PRs into a single PR from our side (we have quirkiness with running the full CI from external forks).

Before I can do that, though, please read and follow the CONTRIBUTING.md. Once you've filled out the CLA, ping me here please 👍

[mikechu-optimizely]

Before I can do that, though, please read and follow the CONTRIBUTING.md. Once you've filled out the CLA, ping me here please 👍

I do not currently see your name in our CLA signed list @localheinz. Definitely, fill out the CLA form when you get a moment. I'm not allowed to use any open-source contributions without the submission…. Uggg 😩 Legal.

[localheinz]

@mikechu-optimizely

Done!

[localheinz]

@mikechu-optimizely

Would you like me to apply the changes from all of my pull requests here into a single pull request?

[mikechu-optimizely]

@mikechu-optimizely

Would you like me to apply the changes from all of my pull requests here into a single pull request?

That'd be super helpful. Yes, please. I can pull them off your fork much more completely that way.

Thanks and cheers.

[localheinz]

@mikechu-optimizely

I have cherry-picked the commits from #274, #275, and #276 into the branch for this pull request.

[mikechu-optimizely]

Besten Dank, Herr!

I created our internal ticket (FSSDK-9630) to get this into the main branch.

[mikechu-optimizely]

We'll be pointing this tomorrow and then rolling it into the next sprint (ahhh ceremonies and planning).

[mikechu-optimizely]

Point given (thanks for shortening that for us). Moved into planning for the next sprint (starts next week)

[mikechu-optimizely]

Yikes. This slipped through our planning. I just noticed it when preparing to cut a patch version.

Review looks good. I need to bring a copy into our org so our back-end CI tests run.

[mikechu-optimizely]

LGTM

[mikechu-optimizely]

@localheinz Decided not to sort-packages and remove the ReturnTypeWillChange decorators?

[localheinz]

@mikechu-optimizely

Rebased on top of master and forgot that you wanted commits cherry-picked into this branch.

[mikechu-optimizely]

Thanks. Pulling this into the org so the CI runs....

[mikechu-optimizely]

I'm closing this PR in exchange for #281