Suppress jsonSerialize deprecation notice for php 8.1+#242
Merged
msohailhussain merged 1 commit intooptimizely:masterfrom May 11, 2022
samybasset:samybasset/add-return-type-will-change-attribute-to-json-serialize-method
Merged
Suppress jsonSerialize deprecation notice for php 8.1+#242msohailhussain merged 1 commit intooptimizely:masterfrom samybasset:samybasset/add-return-type-will-change-attribute-to-json-serialize-method
msohailhussain merged 1 commit intooptimizely:masterfrom
samybasset:samybasset/add-return-type-will-change-attribute-to-json-serialize-method
Conversation
Since php 8.1 internal functions are using proper return types. This results in deprecation notices for some methods. To supress this for php8.1 the ReturnTypeWillChange attribute is introduced. For more info check out https://stitcher.io/blog/new-in-php-81#interal-method-return-types-rfc
Contributor
Author
|
hi @msohailhussain, could this PR be reviewed? Thanks in advance 😄 |
Contributor
Sure let me review it. |
Contributor
Author
|
@msohailhussain Is there something blocking this pull request? Would we be able to merge this? 😄 |
|
And please tag a new release as soon as this is merged. Thank you :) |
Contributor
|
Next week, we are planning to release. |
Contributor
|
@samybasset please sign the CLA https://docs.google.com/forms/d/e/1FAIpQLSf9cbouWptIpMgukAKZZOIAhafvjFCV8hS00XJLWQnWDFtwtA/viewform Your PR is all good, just need your signed CLA. |
samybasset
deleted the
samybasset/add-return-type-will-change-attribute-to-json-serialize-method
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since php 8.1 internal functions are using proper return types. This results in deprecation notices for some of the methods. To suppress the notice for php8.1+ the proper return type or the new
ReturnTypeWillChangeattribute needs to be added to the method in question. If extending a class or implementing an interface (likeJsonSerializable), the return type or attribute needs to be added as well. For more info check out https://stitcher.io/blog/new-in-php-81#interal-method-return-types-rfc