Merged
Conversation
fscelliott
commented
Mar 30, 2020
Contributor
Author
fscelliott
left a comment
There was a problem hiding this comment.
couple comments:
-sorry, is there a prettifier or something I should run to avoid the long lines I've created here?
- don't quite get the JWT endpoint --- where are you configuring expiration/sdk? is it reflected in the datafile? Is "Optimizely config" endpoint a subset of the datafile, or the datafile itself...?
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 27 27
Lines 1241 1241
=======================================
Hits 1021 1021
Misses 165 165
Partials 55 55 Continue to review full report at Codecov.
|
Co-Authored-By: JC <40373238+juancarlostong@users.noreply.github.com>
Contributor
Author
|
@juancarlostong I merged your suggestion. Are you ready to approve? |
juancarlostong
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues