Skip to content

Fix typing warnings with ty#878

Merged
ogenstad merged 1 commit intoinfrahub-developfrom
pog-fix-typing-warnings
Mar 20, 2026
Merged

Fix typing warnings with ty#878
ogenstad merged 1 commit intoinfrahub-developfrom
pog-fix-typing-warnings

Conversation

@ogenstad
Copy link
Contributor

Why

Running "ty check ." produced warnings in the console but with a successful exit status. This leads to extra noise when running the command.

What changed

  • Changed the configuration for these warnings to instead report an error
  • Update tests so that the linting passed.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 665cd24
Status: ✅  Deploy successful!
Preview URL: https://529cdd80.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-fix-typing-warnings.infrahub-sdk-python.pages.dev

View logs

@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Warning

Rate limit exceeded

@ogenstad has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a94f23a3-1d01-4350-9431-03b5e413e7e1

📥 Commits

Reviewing files that changed from the base of the PR and between 9871167 and 665cd24.

📒 Files selected for processing (2)
  • pyproject.toml
  • tests/unit/sdk/pool/test_allocate.py
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                 Coverage Diff                  @@
##           infrahub-develop     #878      +/-   ##
====================================================
+ Coverage             80.62%   80.79%   +0.17%     
====================================================
  Files                   119      119              
  Lines                 10335    10312      -23     
  Branches               1550     1539      -11     
====================================================
- Hits                   8333     8332       -1     
+ Misses                 1475     1471       -4     
+ Partials                527      509      -18     
Flag Coverage Δ
integration-tests 40.21% <ø> (+0.14%) ⬆️
python-3.10 52.17% <ø> (+0.32%) ⬆️
python-3.11 52.15% <ø> (+0.32%) ⬆️
python-3.12 52.15% <ø> (+0.32%) ⬆️
python-3.13 52.17% <ø> (+0.32%) ⬆️
python-3.14 53.87% <ø> (+0.35%) ⬆️
python-filler-3.12 23.87% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review March 20, 2026 12:39
@ogenstad ogenstad requested a review from a team as a code owner March 20, 2026 12:39
@ogenstad ogenstad merged commit a75a893 into infrahub-develop Mar 20, 2026
21 checks passed
@ogenstad ogenstad deleted the pog-fix-typing-warnings branch March 20, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants