🌱 Export variable fields

[m1kola]

To do:

• Handle this from Part 2: Reduce number of variable sources. Bundle variables. #498.
• Handle this from 🌱 Part 4: Reduce number of variable sources. Required packages #500
• Handle this from 🌱 Part 5: Reduce number of variable sources. Final cleanup #501
• Update assertions like this with go-cmp in variablesources/installed_package_test.go.

Description

Experiment to make testing a bit easier.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[m1kola]

This is not the best example, but I'm trying to find a nicier way to do these comparisons.

E.g. in #498 we do this:

	gocmpopts := []cmp.Option{
		cmpopts.IgnoreUnexported(sync.RWMutex{}),
		cmp.AllowUnexported(
			sync.RWMutex{},
			olmvariables.BundleVariable{},
			input.SimpleVariable{},
			constraint.DependencyConstraint{},
			catalogmetadata.Bundle{},
		),
		cmpopts.IgnoreFields(
			// Do not compare a func field
			catalogmetadata.PackageRequired{}, "SemverRange",
		),
	}
	require.Empty(t, cmp.Diff(bundles, expectedVariables, gocmpopts...))

[stevekuznetsov]

Haven't had enough time to review all of it - but you likely do not want to compare internals of sync.RWMutex - perhaps even of the others. For each, ask if it's possible or valid for the third-party package to change the implementation detail of unexported fields and if that would be a bona-fide concern for the caller here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c7291d) 83.92% compared to head (93ebbc9) 83.97%.
Report is 48 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   83.92%   83.97%   +0.05%     
==========================================
  Files          23       23              
  Lines         877      880       +3     
==========================================
+ Hits          736      739       +3     
  Misses         96       96              
  Partials       45       45              

Flag	Coverage Δ
e2e	65.56% <100.00%> (+0.11%)	⬆️
unit	78.76% <100.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[m1kola]

Closing for now, but I'm hoping to come back to it at some point.