🌱 Part 3: Reduce number of variable sources. Installed packages#499
Merged
joelanford merged 1 commit intooperator-framework:mainfrom Nov 6, 2023
Merged
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
m1kola
changed the title
This was referenced Oct 31, 2023
m1kola
force-pushed
the
shrink_variable_sources_p3
branch
from
48523f5 to
b3ce584
Compare
4 tasks
m1kola
changed the title
m1kola
changed the title
m1kola
force-pushed
the
shrink_variable_sources_p3
branch
3 times, most recently
from
fd46b2f to
3f60963
Compare
m1kola
force-pushed
the
shrink_variable_sources_p3
branch
from
3f60963 to
611072a
Compare
Member
Author
|
Will keep in draft for now. I think "[FAIL] Operator Install when An operator is installed from an operator catalog [It] resolves again when a new catalog is available" failure is a legit one. From a quick look I do not see what is causing it. Everything else seems to be a result of it (looks like some dependency between e2e tests). |
m1kola
force-pushed
the
shrink_variable_sources_p3
branch
3 times, most recently
from
5dabe8f to
deb7a6f
Compare
Member
Author
it was legit issue: I was doing things in incorrect order in
Created an issue for this: #512 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ncdc
reviewed
Nov 3, 2023
everettraven
reviewed
Nov 3, 2023
4 tasks
m1kola
force-pushed
the
shrink_variable_sources_p3
branch
from
220ee92 to
d2a06e8
Compare
joelanford
reviewed
Nov 6, 2023
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
force-pushed
the
shrink_variable_sources_p3
branch
from
d2a06e8 to
cd784a0
Compare
ncdc
approved these changes
Nov 6, 2023
Member
|
@joelanford any other comments? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
==========================================
- Coverage 84.41% 84.24% -0.18%
==========================================
Files 23 23
Lines 892 895 +3
==========================================
+ Hits 753 754 +1
- Misses 95 96 +1
- Partials 44 45 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ncdc
changed the title
4 tasks
joelanford
approved these changes
Nov 6, 2023
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 8, 2025
…ework#499) Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.22.0 to 2.22.2. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.22.0...v2.22.2) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spliting #460 into smaller chunks. Related to #437
In this part I extract code related to creating installed package variables from
InstalledPackageVariableSourceandBundleDeploymentVariableSourceinto a separate function.InstalledPackageVariableSourcegets removed in this PR.BundleDeploymentVariableSourcewill be removed later in #501Reviewer Checklist