(vendor) k8s + catalogd bump#475
Conversation
anik120
force-pushed
the
bump-k8s-catalogd
branch
from
7664125 to
4801c9a
Compare
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
Aside from the lint warning this looks good to me
|
Heads up, I think the I'm investigating. Edit: It looks like some of the failures across our PRs were due to golang/go#63684 and I no longer see issues in other PRs. So it might be related to this PR after all? |
anik120
force-pushed
the
bump-k8s-catalogd
branch
2 times, most recently
from
1b801f5 to
efa84d8
Compare
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
Needs a go.mod conflict resolution, but looks good to me otherwise.
Correction: |
anik120
force-pushed
the
bump-k8s-catalogd
branch
6 times, most recently
from
6dc5483 to
645f15f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 23 23
Lines 877 877
=======================================
Hits 734 734
Misses 97 97
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
anik120
force-pushed
the
bump-k8s-catalogd
branch
3 times, most recently
from
af4dfb7 to
cf58cf7
Compare
openshift-merge-robot
added
the
needs-rebase
anik120
force-pushed
the
bump-k8s-catalogd
branch
from
cf58cf7 to
c6215a2
Compare
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com> stand up registry for e2e Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
and update the operator-framework-e2e test to use an on-cluster image registry and build+push the test catalog to it Signed-off-by: Bryce Palmer <everettraven@gmail.com>
everettraven
force-pushed
the
bump-k8s-catalogd
branch
from
c6215a2 to
70bf85c
Compare
openshift-merge-robot
removed
the
needs-rebase
m1kola
left a comment
m1kola
left a comment
There was a problem hiding this comment.
I went through about half of it. So far noticed only a minor thing.
|
|
||
| Usage: | ||
| setup.sh [OPERATOR_SDK] [CONTAINER_RUNTIME] [KUSTOMIZE] [KIND] [KIND_CLUSTER_NAME] | ||
| setup.sh [OPERATOR_SDK] [CONTAINER_RUNTIME] [KUSTOMIZE] [KIND] [KIND_CLUSTER_NAME] [NAMESPACE] |
There was a problem hiding this comment.
It looks like help text above needs to be updated.
Also - do we want to have a check for non-empty namespace? Similar to CATALOG_IMG, REG_PKG_NAME, etc?
There was a problem hiding this comment.
Ah, does look like I forgot to increase the argument count there. I think it could be helpful to check for a non-empty namespace but I think requiring it to be an argument alleviates the need for that. You'd have to explicitly make it an empty value
…mework#475) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
6 participants
Description
Reviewer Checklist