Add ForceSemverUpgradeConstraints feature gate#438
Merged
m1kola merged 1 commit intooperator-framework:mainfrom Oct 6, 2023
Merged
Add ForceSemverUpgradeConstraints feature gate#438m1kola merged 1 commit intooperator-framework:mainfrom
m1kola merged 1 commit intooperator-framework:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
==========================================
- Coverage 84.00% 83.76% -0.24%
==========================================
Files 23 23
Lines 844 844
==========================================
- Hits 709 707 -2
- Misses 93 94 +1
- Partials 42 43 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
everettraven
approved these changes
Oct 5, 2023
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
force-pushed
the
395_feature_gate
branch
from
e7689df to
c9a87a5
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
everettraven
approved these changes
Oct 6, 2023
LalatenduMohanty
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Dec 19, 2024
…perator-framework#438) When used in conjuction with a "tag-only" registries.conf mirror registry configuration, our containers/image unpacker fails. This is because we resolve a canonical ref from the tag, and then use the digest-based reference to actually copy the image, thus thwarting the tag-only configuration. This commit ensures that we always copy the image using the reference provided in the spec. Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #395
Reviewer Checklist