operator_controller_test: ensure we cleanup after each spec#257
Merged
joelanford merged 1 commit intooperator-framework:mainfrom Jun 8, 2023
Merged
Conversation
Closed
joelanford
force-pushed
the
operator-controller-test-cleanup
branch
from
3c1cff4 to
623d98b
Compare
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
operator-controller-test-cleanup
branch
from
623d98b to
adcb836
Compare
joelanford
commented
Jun 8, 2023
| Expect(cond.Message).To(Equal("installation has not been attempted as resolution failed")) | ||
| }) | ||
| }) | ||
| When("the existing operator status is based on bundleDeployment", func() { |
Member
Author
There was a problem hiding this comment.
As of #134, this block no longer has any specs in it. So it is unused. Therefore removing it.
joelanford
commented
Jun 8, 2023
| Expect(err).To(Not(HaveOccurred())) | ||
| }) | ||
| }) | ||
| When("an invalid semver is provided that bypasses the regex validation", func() { |
Member
Author
There was a problem hiding this comment.
Moved this block into the When("the operator exists") so that it also passes through the verifyInvariants check that we apply to operators after calling Reconcile.
everettraven
reviewed
Jun 8, 2023
everettraven
approved these changes
Jun 8, 2023
Contributor
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
Just a question, but this looks good to me overall
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was reviewing #251 and noticed that there were leftover items in the envtest etcd after several operator_controller_test specs completed.
This PR:
Reviewer Checklist