E2E flake - object is being deleted: catalogs.catalogd.operatorframework.io "test-catalog" already exists

[m1kola]

I think this happens because we delete the test catalog here:

operator-controller/test/e2e/install_test.go

Line 158 in f147e61

Expect(c.Delete(ctx, operatorCatalog)).To(Succeed())

And then without waiting we re-create the catalog with the same name here:

operator-controller/test/e2e/install_test.go

Lines 173 to 175 in f147e61

	By("creating an Operator catalog with the desired package")
	var err error
	operatorCatalog, err = createTestCatalog(ctx, testCatalogName, os.Getenv(testCatalogRefEnvVar))

---

Example is here:

  [FAILED] Unexpected error:
      <*errors.StatusError | 0xc00032fc20>: 
      object is being deleted: catalogs.catalogd.operatorframework.io "test-catalog" already exists
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "object is being deleted: catalogs.catalogd.operatorframework.io \"test-catalog\" already exists",
              Reason: "AlreadyExists",
              Details: {
                  Name: "test-catalog",
                  Group: "catalogd.operatorframework.io",
                  Kind: "catalogs",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 409,
          },
      }
  occurred
  In [It] at: /home/runner/work/operator-controller/operator-controller/test/e2e/install_test.go:176 @ 11/10/23 15:56:52.44

[m1kola]

I think I either introduced it in #534 or - more likely - I unmasked it this PR: #534 addresses #512 which was in exact same area of code.

I'll look into this.