Incorrect filtering of bundles for semver upgrades

[m1kola]

I just realised that #444 has insufficient filtering of bundles for semver based upgrades. Here we only filter all bundles based on version:

operator-controller/internal/resolution/variablesources/installed_package.go

Line 111 in 3fc434d

upgradeEdges := catalogfilter.Filter(allBundles, catalogfilter.InMastermindsSemverRange(wantedVersionRangeConstraint))

allBundles includes all bundles from all catalogs for all packages. This code must also filter by package name.

[m1kola]

Test case for this bug (can be applied on top of 3fc434d):

diff --git a/internal/resolution/variablesources/installed_package_test.go b/internal/resolution/variablesources/installed_package_test.go
index 1accbb8..f01fce7 100644
--- a/internal/resolution/variablesources/installed_package_test.go
+++ b/internal/resolution/variablesources/installed_package_test.go
@@ -181,6 +181,15 @@ func TestInstalledPackageVariableSource(t *testing.T) {
                        }},
                        InChannels: []*catalogmetadata.Channel{&channel},
                },
+               {Bundle: declcfg.Bundle{
+                       Name:    "some-other-package.v2.3.0",
+                       Package: "some-other-package",
+                       Image:   "registry.io/repo/some-other-package@v2.3.0",
+                       Properties: []property.Property{
+                               {Type: property.TypePackage, Value: json.RawMessage(`{"packageName": "some-other-package", "version": "2.3.0"}`)},
+                       }},
+                       InChannels: []*catalogmetadata.Channel{&channel},
+               },
        }

        fakeCatalogClient := testutil.NewFakeCatalogClient(bundleList)