-
Notifications
You must be signed in to change notification settings - Fork 236
docs: read-cache-after-write consistency and event filtering #3193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
207c267
wip
csviri 4a7a2be
wip
csviri 49dd490
wip
csviri 58178e3
wip
csviri fec5c07
Update docs/content/en/docs/documentation/reconciler.md
csviri aed8bc1
Update docs/content/en/docs/documentation/reconciler.md
csviri a6a9fe4
Update docs/content/en/docs/documentation/reconciler.md
csviri ad1fc3c
Apply suggestions from code review
csviri d9a21ad
wip
csviri dfdea7b
Update docs/content/en/docs/documentation/reconciler.md
csviri 374cc70
Update docs/content/en/docs/documentation/reconciler.md
csviri aa1b679
wip
csviri 9552d6a
fix: grammar
metacosm 08184fa
docs: restructure and improve wording to make things clearer
metacosm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this: this doesn't seem standard MD and I'm not sure we should be adding formatting instructions that only work with the current publishing mechanism, i.e. it should be possible to render the documentation correctly locally, just using any MD reader.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not possible even now, like for exmaple the mermaid pics are not standard stuff. We use hugo + docsy, you need hugo to render the document anyways, and this is standard way in docsy; and mainly looks great :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see: https://www.docsy.dev/docs/content/shortcodes/
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw you can always just see the docs by running
hugo servein docs directory. Now works with latest hugo. So if you install hugo with brew it should work like a charm to see the result.