Reconcile utils new alg#3114
Reconcile utils new alg#3114shawkins wants to merge 0 commit intooperator-framework:reconcile-utils-new-algfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
shawkins
force-pushed
the
reconcile-utils-new-alg
branch
from
62af67c to
22d8c55
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@csviri sorry about the pr confusion. Starting from a gh co put things in a different state that I'm used to. This should be in a better state now. To continue from #3109 (comment) - I'm using the term obsolete in the TemporaryResourceCache. We previously had logic in onEvent that distinguished these cases, so I think we want to continue with that. |
sure fine with that, thx! |
| // now expect an event with the matching resourceVersion to be known after the put | ||
| result = temporaryResourceCache.onAddOrUpdateEvent(nextResource); | ||
| assertThat(result).isFalse(); | ||
| assertThat(result).isTrue(); |
There was a problem hiding this comment.
This is a foundamental question with the new design, that if there is no explicit event filtering, we should propagate the new event for our update or more recent (larger resource version). So this should be false based on that.
shawkins
force-pushed
the
reconcile-utils-new-alg
branch
from
22d8c55 to
eaa50d1
Compare
3 participants
No description provided.