Draft
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
xstefank
approved these changes
Jul 24, 2025
| public static final String RESOURCE_NAME2 = "test2"; | ||
|
|
||
| @RegisterExtension LocallyRunOperatorExtension operator = buildOperator(); | ||
| @RegisterExtension LocallyRunOperatorExtension extension = buildOperator(); |
...operatorsdk/operator/dependent/primarytosecondaydependent/PrimaryToSecondaryDependentIT.java
Outdated
Show resolved
Hide resolved
openshift-ci
bot
added
the
do-not-merge/work-in-progress
metacosm
reviewed
Aug 4, 2025
|
|
||
| additionalCustomResourceDefinitions.forEach(this::applyCrd); | ||
| for (var ref : reconcilers) { | ||
| this.operator = new Operator(configurationServiceOverrider); |
Collaborator
There was a problem hiding this comment.
This shouldn't be done in the loop as the operator is re-initialized for each reconciler.
Collaborator
Author
There was a problem hiding this comment.
hi @metacosm this is wip, pls ignore the PR while not marked ready
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com