Closed
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
xstefank
approved these changes
Jul 22, 2025
Collaborator
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
remove the todo please but otherwise LGTM
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
force-pushed
the
sec-to-primary-as-index
branch
from
0fd7580 to
17d40cc
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
This reverts commit faf9bdf.
Collaborator
Author
|
replaced by: #2881 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the issues that after startup accessing resources through
context.getSecondaryResources(...)might happen that not all the initial resources are returned. Moving the index to informer solved this problem for base level API.For dependent resources where we explicitly cache the create / updated resource we have to maintain a tempral cache until the resource is visible for the informer.