Bug [2099580] - This fix will take care of deletion part of CR in java Operator.#97
Merged
laxmikantbpandhare merged 2 commits intooperator-framework:mainfrom Jul 22, 2022
laxmikantbpandhare:bug-fix-2099580
Merged
Bug [2099580] - This fix will take care of deletion part of CR in java Operator.#97laxmikantbpandhare merged 2 commits intooperator-framework:mainfrom laxmikantbpandhare:bug-fix-2099580
laxmikantbpandhare merged 2 commits intooperator-framework:mainfrom
laxmikantbpandhare:bug-fix-2099580
Conversation
Collaborator
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
@laxmikantbpandhare Could we also update the sample in the testdata/ directory so that our sample is up to date with our tutorial?
Member
Author
|
Sure @everettraven thanks for pointing out |
everettraven
approved these changes
Jul 22, 2022
Collaborator
There was a problem hiding this comment.
/lgtm
holding until PR title is updated to match format of Bug xxxxxx: summary as mentioned by @jmrodri offline
/hold
openshift-ci
bot
added
the
do-not-merge/hold
laxmikantbpandhare
changed the title
laxmikantbpandhare
changed the title
Collaborator
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the bug from Bugzilla - 2099580
I created issue #94 this also get fixed after the merge of this PR.