Skip to content

Rename to v1alpha#5

Merged
jmrodri merged 1 commit intooperator-framework:mainfrom
jmrodri:rename-to-v1alpha
Apr 30, 2021
Merged

Rename to v1alpha#5
jmrodri merged 1 commit intooperator-framework:mainfrom
jmrodri:rename-to-v1alpha

Conversation

@jmrodri
Copy link
Member

@jmrodri jmrodri commented Apr 22, 2021

Signed-off-by: jesus m. rodriguez jmrodri@gmail.com

@jmrodri
Rename to v1alpha
7461902 
Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
@jmrodri jmrodri force-pushed the rename-to-v1alpha branch from bd6ab77 to 7461902 Compare April 29, 2021 14:56
laxmikantbpandhare
laxmikantbpandhare approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1alpha changes looks perfect.

@laxmikantbpandhare
Copy link
Member

laxmikantbpandhare commented Apr 29, 2021 •
edited
Loading

@jmrodri - One question for this PR - Memcached.java file has field called Version as v1. Do we need to change it to v1alpha1?

@jmrodri jmrodri merged commit 5219dea into operator-framework:main Apr 30, 2021
@jmrodri
Copy link
Member Author

jmrodri commented Apr 30, 2021

@jmrodri - One question for this PR - Memcached.java file has field called Version as v1. Do we need to change it to v1alpha1?
I merged before I saw your question. No, the Version in Memcached.java is the version of that CRD. The v1alpha I am using in this PR is the version of the PLUGIN.

@jmrodri jmrodri mentioned this pull request Apr 30, 2021
Closed
26 tasks
@laxmikantbpandhare
Copy link
Member

laxmikantbpandhare commented Apr 30, 2021

@jmrodri - One question for this PR - Memcached.java file has field called Version as v1. Do we need to change it to v1alpha1?
I merged before I saw your question. No, the Version in Memcached.java is the version of that CRD. The v1alpha I am using in this PR is the version of the PLUGIN.

That's perfect then. Thank you for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laxmikantbpandhare laxmikantbpandhare laxmikantbpandhare approved these changes

@sujil02 sujil02 Awaiting requested review from sujil02

@theishshah theishshah Awaiting requested review from theishshah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmrodri @laxmikantbpandhare