Guidelines for Contribution and PR review.#2
Merged
theishshah merged 3 commits intooperator-framework:mainfrom Feb 16, 2021
laxmikantbpandhare:main
Merged
Guidelines for Contribution and PR review.#2theishshah merged 3 commits intooperator-framework:mainfrom laxmikantbpandhare:main
theishshah merged 3 commits intooperator-framework:mainfrom
laxmikantbpandhare:main
Conversation
theishshah
suggested changes
Feb 15, 2021
theishshah
left a comment
theishshah
left a comment
There was a problem hiding this comment.
Added sections look good, just the one nit in the codes style.
jmrodri
requested changes
Feb 15, 2021
Member
jmrodri
left a comment
jmrodri
left a comment
There was a problem hiding this comment.
Some minor changes. Overall nicely done.
jmrodri
approved these changes
Feb 16, 2021
theishshah
approved these changes
Feb 16, 2021
Closed
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Contribution and PR review.