Improving the performance of check_datasets_active, modifying unit test #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
requested changes
Oct 29, 2020
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
Looks good 👍 only two minor remarks
PGijsbers
reviewed
Oct 29, 2020
openml/datasets/functions.py
Outdated
| """ | ||
| dataset_list = list_datasets(status="all") | ||
| dataset_list = list_datasets( | ||
| dataset_ids=dataset_ids, |
Collaborator
There was a problem hiding this comment.
Suggested change
| dataset_ids=dataset_ids, | |
| data_id=dataset_ids, |
Collaborator
There was a problem hiding this comment.
Actually this is a rather important one that hadn't caught my eye first time around 😅
Member
Author
There was a problem hiding this comment.
Strange, I got a suggestion for that and the function had no argument like that at all :S. Nice catch.
Collaborator
There was a problem hiding this comment.
like because of the **kwargs (used to allow all filters)
PGijsbers
requested changes
Oct 29, 2020
PGijsbers
approved these changes
Oct 29, 2020
mfeurer
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #671
What does this PR implement/fix? Explain your changes.
Improves the performance of the function
check_datasets_activeby querying only for the given datasets, instead of all datasets. Furthemore, the error throwing behavior can be controller by the user.How should this PR be tested?
Existing unit test which was modified.