Speed up tests #977
Merged
Speed up tests #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test does not require the list of flows to be updated, to a single cached version will do fine (this call otherwise would take ~40 seconds).
Downloading a run takes a non-significant amount of time (est. 300ms on my current setup). It is unnecessary to compare against all >=100 runs, while a handful should do fine (perhaps even just one should do).
The batch size required in some pages over 40 pages to be loaded, which increased the workload unnecessarily. These changing preserve pagination tests while lowering the amount of round trips required.
Since it is already covered by test_run_and_upload_randomsearch.
Speeds up ~25x, and reduces network traffic.
Loading a page takes ~600ms. I don't think testing with 3 pages is any worse than 10. I also think this is an ideal candidate of test that could be split up into (1) testing the url is generated correctly, (2) testing a pre-cached result is parsed correctly and (3) testing the url gives the expected response (the actual integration test).
If the test is that swapped parameters work, we don't need a complicated pipeline or dataset.
mfeurer
reviewed
Oct 27, 2020
mfeurer
reviewed
Oct 27, 2020
Some tests support both, by checking e.g. only a few runs vs all runs.
Collaborator
Author
|
I think this seems like a reasonable set of changes for one PR, so I would like to have some feedback (or approval) 👍 |
mfeurer
reviewed
Oct 27, 2020
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
This looks great, but I have once change request. Also, I'd like to see what this does in practice. And finally, there are some failures on appveyor :(
To cover for the skipping of test_get_run_trace
mfeurer
approved these changes
Oct 29, 2020
mfeurer
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements to tests that should reduce test time without affecting test quality.