More robust handling of openml_url #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into issues when the openml server config is not exactly 'https://www.openml.org/api/v1/xml', e.g. I had 'https://www.openml.org/api/v1'. I only noticed when getting a bad dataset url. This edit makes the API more robust against how exactly the server URL is set in the config.
Contributor
Author
|
This will also allow adding a version 2 of the API without breaking the URLs. |
mfeurer
approved these changes
Jul 1, 2020
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
I cannot reproduce the original problem, but this change is definitely an improvement.
mfeurer
pushed a commit
that referenced
this pull request
Jul 2, 2020
* Add Flake8 configuration Uses the configuration from ci_scripts * Add mypy configuration file Based on the ci_scripts parameters. * Pre-commit mypy flake8, add flake8 excludes Any venv folder does not need flake8. The example directory got flake8 warnings so I assumed it should be excluded. * Add Black to pre-commit Add ignore E203 as Black will observe PEPs specification for white space around a colon it is next to an expression. * Set max line length to 100 * Blacken code There are a few places where big indentation is introduced that may warrant refactoring so it looks better. I did not refactor anything yet, but did exlude three (?) lists (of ids) to not be formatted. * Add unit tests to flake8 and mypy pre-commit * Use pre-commit for flake8, mypy and black checks This ensures it runs with the same versions and settings as developers. * Update docs, add 'test' dependencies Add two other developer dependencies not strictly required for unit tests, but required for development. I think the overlap between people who want to execute unit tests and perform commits is (close to) 100% anyway. * Uninstall pytest-cov on appveyor ci It seems to cause an error on import due to a missing sqlite3 dll. As we don't check coverage anyway, hopefully just uninstalling is sufficient. * Add -y to uninstall * Sphinx issue fix (#923) * Sphinx issue fix * Removing comment * More robust handling of openml_url (#921) I ran into issues when the openml server config is not exactly 'https://www.openml.org/api/v1/xml', e.g. I had 'https://www.openml.org/api/v1'. I only noticed when getting a bad dataset url. This edit makes the API more robust against how exactly the server URL is set in the config. * format for black artifacts * Add Flake8 configuration Uses the configuration from ci_scripts * Add mypy configuration file Based on the ci_scripts parameters. * Pre-commit mypy flake8, add flake8 excludes Any venv folder does not need flake8. The example directory got flake8 warnings so I assumed it should be excluded. * Add Black to pre-commit Add ignore E203 as Black will observe PEPs specification for white space around a colon it is next to an expression. * Set max line length to 100 * Blacken code There are a few places where big indentation is introduced that may warrant refactoring so it looks better. I did not refactor anything yet, but did exlude three (?) lists (of ids) to not be formatted. * Add unit tests to flake8 and mypy pre-commit * Use pre-commit for flake8, mypy and black checks This ensures it runs with the same versions and settings as developers. * Update docs, add 'test' dependencies Add two other developer dependencies not strictly required for unit tests, but required for development. I think the overlap between people who want to execute unit tests and perform commits is (close to) 100% anyway. * Uninstall pytest-cov on appveyor ci It seems to cause an error on import due to a missing sqlite3 dll. As we don't check coverage anyway, hopefully just uninstalling is sufficient. * Add -y to uninstall * format for black artifacts Co-authored-by: Neeratyoy Mallik <[email protected]> Co-authored-by: Joaquin Vanschoren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/fix? Explain your changes.
I ran into issues when the openml server config is not exactly 'https://www.openml.org/api/v1/xml', e.g. I had 'https://www.openml.org/api/v1'.
I only noticed when getting a bad dataset url.
This edit makes the API more robust against how exactly the server URL is set in the config.
How should this PR be tested?
set config to:
server=https://www.openml.org/api/v1
And run
The URL should be correct.