add: test for dataset comparison and ignore fields #1370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsider for comparing it.
…o test_comparisons
eddiebergman
approved these changes
Oct 16, 2024
Collaborator
eddiebergman
left a comment
eddiebergman
left a comment
There was a problem hiding this comment.
Makes sense, not really sure on the full logic of the equality for datasets but in terms of the change and test, looks good!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1370 +/- ##
===========================================
+ Coverage 84.05% 84.17% +0.11%
===========================================
Files 38 38
Lines 5301 5303 +2
===========================================
+ Hits 4456 4464 +8
+ Misses 845 839 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #981 and #577
Closes #981
Closes #577
Co-authored-by: ArlindKadra [email protected]