-
-
Notifications
You must be signed in to change notification settings - Fork 211
fix(config): Fix XDG_X_HOME env vars, add OPENML_CACHE_DIR env var #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1359 +/- ##
===========================================
+ Coverage 81.71% 84.27% +2.56%
===========================================
Files 38 38
Lines 5261 5304 +43
===========================================
+ Hits 4299 4470 +171
+ Misses 962 834 -128 ☔ View full report in Codecov by Sentry. |
PGijsbers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏 for your 👆 contribution 🙇
Unfortunately 👿 there are some issues 💥 that you probably want to have a look 👀 at.
Good luck 🤞
|
Cool 💯 |
PGijsbers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌈 🏆
Fixes two issues related to
XDG_CONFIG_DIRandXDG_CACHE_DIR, in which we were not adding the"openml"suffix to the path, i.e. we had:${XDG_CONFIG_HOME}/configinstead of${XDG_CONFIG_HOME}/openml/config${XDG_CACHE_HOME}/configinstead of${XDG_CACHE_HOME}/openml/..To keep things backwards compatible:
... and also:
You can now specify
OPENML_CACHE_DIRas an environment variable