Skip to content

Conversation

@eddiebergman
Copy link
Collaborator

Please see issue #1111

Tried to be minimally invasive and make it match what was there existing.
Also added the url to the error as it kept a None in the printed message

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (bb0a130) to head (a68011c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1356      +/-   ##
===========================================
+ Coverage    81.71%   84.58%   +2.87%     
===========================================
  Files           38       38              
  Lines         5261     5261              
===========================================
+ Hits          4299     4450     +151     
+ Misses         962      811     -151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a simple test.

@eddiebergman
Copy link
Collaborator Author

Test added

@eddiebergman eddiebergman merged commit 891f4a6 into develop Oct 14, 2024
@eddiebergman eddiebergman deleted the fix-better-error-message-on-invalid-dataset branch October 14, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants