Allow unknown task types on the server #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
requested changes
Feb 22, 2023
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
Accept with minor revision :-)
mfeurer
force-pushed
the
allow_unknown_task_types
branch
from
6f134b4 to
5152f2b
Compare
mfeurer
force-pushed
the
allow_unknown_task_types
branch
from
5152f2b to
8464132
Compare
PGijsbers
approved these changes
Feb 23, 2023
PGijsbers
pushed a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* Allow unknown task types on the server * Applied black to openml/tasks/functions.py * Some more fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents new task types from crashing the Python API, as the new task type ID would not be part of the ENUM, causing a
ValueError.