Skip to content

Use GET instead of POST for flow exist #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 2 commits into from
Jun 28, 2022
Merged

Use GET instead of POST for flow exist #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
408dc9c
Use GET instead of POST for flow exist
PGijsbers Jun 27, 2022
bebb1e5
Add flow_exist fix notice
PGijsbers Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/progress.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Changelog
~~~~~~
* FIX#1030: ``pre-commit`` hooks now no longer should issue a warning.
* FIX#1110: Make arguments to ``create_study`` and ``create_suite`` that are defined as optional by the OpenML XSD actually optional.
* FIX#1147: ``openml.flow.flow_exists`` no longer requires an API key.
* MAIN#1088: Do CI for Windows on Github Actions instead of Appveyor.
* ADD#1103: Add a ``predictions`` property to OpenMLRun for easy accessibility of prediction data.

Expand Down
2 changes: 1 addition & 1 deletion openml/flows/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def flow_exists(name: str, external_version: str) -> Union[int, bool]:
raise ValueError("Argument 'version' should be a non-empty string")

xml_response = openml._api_calls._perform_api_call(
"flow/exists", "post", data={"name": name, "external_version": external_version},
"flow/exists", "get", data={"name": name, "external_version": external_version},
)

result_dict = xmltodict.parse(xml_response)
Expand Down