Skip to content

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Apr 14, 2021

Reference Issue

Fixes a bug which could occur when using OpenML-Python in a docker container. Initially reported as conda-forge/openml-feedstock#1 (comment) by @BastianZim

When OpenML-Python was trying to create a cache directory as /home/${USER}/.config/openml it would only try to create the openml directory. If the .config directory was also missing, it would fail.

What does this PR implement/fix? Explain your changes.

This PR creates both directories.

How should this PR be tested?

New unit test, or in a docker container built with:

apt update
apt upgrade
apt install python3-dev ipython3 python3-pip git
pip3 install openml

Any other comments?

@BastianZim
Copy link

Thank you!

@mfeurer mfeurer merged commit 46c5021 into develop Apr 14, 2021
@mfeurer mfeurer deleted the fix_docker branch April 14, 2021 08:32
PGijsbers pushed a commit to Mirkazemi/openml-python that referenced this pull request Feb 23, 2023
* fix temp directory creation on container

* add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants