-
-
Notifications
You must be signed in to change notification settings - Fork 211
Measuring runtimes #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measuring runtimes #1031
Conversation
tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py
Outdated
Show resolved
Hide resolved
mfeurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for the failure that you mentioned offline
Should pass with the changes made. |
mfeurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can also remove the flow in this PR as it is not needed and removing it is helpful in reaching this PRs goal.
|
Added a |
| res = format_prediction(regression, *ignored_input) | ||
| self.assertListEqual(res, [0] * 5) | ||
|
|
||
| @pytest.mark.flaky() # appears to fail stochastically on test server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these errors only with loky? If so, we could use multiprocessing as a default here as we don't want to test for a specific backend in this unit test?
* [skip ci] addressing openml#248 * Unit test to test existence of refit time * Refactoring unit test * Fixing unit test failures * Unit test fixing + removing redundant parameter * Debugging stochastic failure of test_joblib_backends unit test * Unit test fix with decorators * Flaky for failing unit test * Adding flaky reruns for unit tests * Fixing setup big * pytest rerun debug * Fixing coverage failure * Debugging coverage failure * Debugging coverage failure * Adding __init__ files in test/ for pytest-cov * Debugging coverage failure * Debugging lean unit test * Debugging loky failure in unit tests * Clean up of debugging stuff
Reference Issue
Addresses #248.