fix: Fix timestamp handling (elapsed; formatting)#111
Merged
Conversation
- Use `utcnow()` instead of `now()` for elapsed time, because the `now()` clock can easily change. I was getting "Search found 8 annotations in -17999.895582 seconds." from some runs of pii_check, and I narrowed it down to `DjangoSearch(config)` changing the clock. Presumably something is hardcoding Eastern Standard Time somewhere. (It's EDT right now!) There might be a better timer utility somewhere, but this should at least be correct when leap seconds and NTP updates aren't involved. :-) - Make the timestamp in the report filename go year-month-day rather than year-day-month. Also make it more compact while I'm in there.
bmtcril
approved these changes
Nov 14, 2024
Contributor
bmtcril
left a comment
bmtcril
left a comment
There was a problem hiding this comment.
Thanks for this! It's been a pain for a long time. It's been lingering for a while, any reason I shouldn't merge and release this change?
Contributor
Author
|
No reason I'm aware of -- I think I just didn't get around to asking for a review at the time. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utcnow()instead ofnow()for elapsed time, because thenow()clock can easily change. I was getting "Search found 8 annotations in -17999.895582 seconds." from some runs of pii_check, and I narrowed it down toDjangoSearch(config)changing the clock. Presumably something is hardcoding Eastern Standard Time somewhere. (It's EDT right now!) There might be a better timer utility somewhere, but this should at least be correct when leap seconds and NTP updates aren't involved. :-)Merge checklist: