Skip to content

[Accton][as5835-54x][as5835-54t] Add set/get sfp module_reset, lpmode, tx_disable(QSFP) functi… #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric271110 wants to merge 3 commits into
base: master
Choose a base branch
from
+254 −18
Open

[Accton][as5835-54x][as5835-54t] Add set/get sfp module_reset, lpmode, tx_disable(QSFP) functi… #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92d5cde
[Accton][as5835-54x][as5835-54t] Add set/get sfp module_reset functi…
eric271110 Mar 11, 2026
fcceec1
[Accton][as5835-54x][as5835-54t] Add set/get sfp lpmode and tx_disabl…
eric271110 Mar 24, 2026
fb0622d
[Accton][as5835-54x][as5835-54t] Add presence check for tx_disable
eric271110 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 124 additions & 2 deletions ...platforms/accton/x86-64/as5835-54t/onlp/builds/x86_64_accton_as5835_54t/module/src/sfpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,25 @@

int sfp_map[] = {28,29,26,30,31,27};

#define QSFP_PORT_MIN 48
#define QSFP_PORT_MAX 53
#define VALIDATE_QSFP(_port) \
do { \
if (_port < QSFP_PORT_MIN || _port > QSFP_PORT_MAX ) \
return ONLP_STATUS_E_UNSUPPORTED; \
} while(0)

#define PORT_BUS_INDEX(port) (sfp_map[port-48])

#define PORT_EEPROM_FORMAT "/sys/bus/i2c/devices/%d-0050/eeprom"
#define MODULE_PRESENT_FORMAT "/sys/bus/i2c/devices/3-0062/module_present_%d"
#define MODULE_PRESENT_ALL_ATTR "/sys/bus/i2c/devices/3-0062/module_present_all"
#define MODULE_RESET_FORMAT "/sys/bus/i2c/devices/3-0062/module_reset_%d"
#define MODULE_LPMODE_FORMAT "/sys/bus/i2c/devices/3-0062/module_lpmode_%d"

/*QSFP tx_disable*/
#define PORT_EEPROM_DEVADDR 0x50
#define QSFP_EEPROM_OFFSET_TXDIS 0x56

/************************************************************
*
Expand Down Expand Up @@ -214,13 +228,121 @@ onlp_sfpi_dev_writew(int port, uint8_t devaddr, uint8_t addr, uint16_t value)
int
onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
{
return ONLP_STATUS_E_UNSUPPORTED;
int rv;
int present = 0;

VALIDATE_QSFP(port);

switch(control)
{
case ONLP_SFP_CONTROL_TX_DISABLE:
case ONLP_SFP_CONTROL_TX_DISABLE_CHANNEL:
{
present = onlp_sfpi_is_present(port);
if(present == 1)
{
/* txdis valid bit(bit0-bit3), xxxx 1111 */
value = value & 0xf;
onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_TXDIS, value);

rv = ONLP_STATUS_OK;
}
else
{
rv = ONLP_STATUS_E_INTERNAL;
}
break;
}

case ONLP_SFP_CONTROL_RESET:
{
if (onlp_file_write_int(value, MODULE_RESET_FORMAT, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to write reset status to port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
rv = ONLP_STATUS_OK;
}
break;
}

case ONLP_SFP_CONTROL_LP_MODE:
{
if (onlp_file_write_int(value, MODULE_LPMODE_FORMAT, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to write lpmode status to port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
rv = ONLP_STATUS_OK;
}
break;
}

default:
rv = ONLP_STATUS_E_UNSUPPORTED;
break;
}

return rv;
}

int
onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
{
return ONLP_STATUS_E_UNSUPPORTED;
int rv;
int tx_dis_val = 0;
int present = 0;

VALIDATE_QSFP(port);

switch(control)
{
case ONLP_SFP_CONTROL_TX_DISABLE:
case ONLP_SFP_CONTROL_TX_DISABLE_CHANNEL:
{
present = onlp_sfpi_is_present(port);
if(present == 1){
/* txdis valid bit(bit0-bit3), xxxx 1111 */
tx_dis_val = onlp_sfpi_dev_readb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_TXDIS);
*value = tx_dis_val;

rv = ONLP_STATUS_OK;
}
else{
rv = ONLP_STATUS_E_INTERNAL;
}
break;
}

case ONLP_SFP_CONTROL_RESET:
{
if (onlp_file_read_int(value, MODULE_RESET_FORMAT, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to read reset status from port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
rv = ONLP_STATUS_OK;
}
break;
}

case ONLP_SFP_CONTROL_LP_MODE:
{
if (onlp_file_read_int(value, MODULE_LPMODE_FORMAT, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to read lpmode status from port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
rv = ONLP_STATUS_OK;
}
break;
}

default:
rv = ONLP_STATUS_E_UNSUPPORTED;
}

return rv;
}

int
Expand Down
146 changes: 130 additions & 16 deletions ...platforms/accton/x86-64/as5835-54x/onlp/builds/x86_64_accton_as5835_54x/module/src/sfpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,48 @@ int sfp_map[] = {
26,30,31,27
};

#define SFP_PORT_MIN 0
#define SFP_PORT_MAX 47
#define QSFP_PORT_MIN 48
#define QSFP_PORT_MAX 53
#define MIN_PORT SFP_PORT_MIN
#define MAX_PORT QSFP_PORT_MAX

#define VALIDATE_SFP(_port) \
do { \
if (_port < SFP_PORT_MIN || _port > SFP_PORT_MAX) \
return ONLP_STATUS_E_UNSUPPORTED; \
} while(0)

#define VALIDATE_QSFP(_port) \
do { \
if (_port < QSFP_PORT_MIN || _port > QSFP_PORT_MAX ) \
return ONLP_STATUS_E_UNSUPPORTED; \
} while(0)

#define VALIDATE_PORT(_port) \
do { \
if (_port < MIN_PORT || _port > MAX_PORT ) \
return ONLP_STATUS_E_UNSUPPORTED; \
} while(0)

#define PORT_BUS_INDEX(port) (sfp_map[port])

#define PORT_EEPROM_FORMAT "/sys/bus/i2c/devices/%d-0050/eeprom"
#define MODULE_PRESENT_FORMAT "/sys/bus/i2c/devices/%d-00%d/module_present_%d"
#define MODULE_RXLOS_FORMAT "/sys/bus/i2c/devices/%d-00%d/module_rx_los_%d"
#define MODULE_TXFAULT_FORMAT "/sys/bus/i2c/devices/%d-00%d/module_tx_fault_%d"
#define MODULE_TXDISABLE_FORMAT "/sys/bus/i2c/devices/%d-00%d/module_tx_disable_%d"
#define MODULE_RESET_FORMAT "/sys/bus/i2c/devices/%d-00%d/module_reset_%d"
#define MODULE_LPMODE_FORMAT "/sys/bus/i2c/devices/%d-00%d/module_lpmode_%d"
#define MODULE_PRESENT_ALL_ATTR "/sys/bus/i2c/devices/%d-00%d/module_present_all"
#define MODULE_RXLOS_ALL_ATTR_CPLD2 "/sys/bus/i2c/devices/3-0061/module_rx_los_all"
#define MODULE_RXLOS_ALL_ATTR_CPLD3 "/sys/bus/i2c/devices/3-0062/module_rx_los_all"

/*QSFP tx_disable*/
#define PORT_EEPROM_DEVADDR 0x50
#define QSFP_EEPROM_OFFSET_TXDIS 0x56

/************************************************************
*
* SFPI Entry Points
Expand Down Expand Up @@ -323,19 +354,59 @@ int
onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
{
int rv;

if (port < 0 || port >= 48) {
return ONLP_STATUS_E_UNSUPPORTED;
}

int addr = (port < 38) ? 61 : 62;
int present = 0;

VALIDATE_PORT(port);

switch(control)
{
case ONLP_SFP_CONTROL_TX_DISABLE:
case ONLP_SFP_CONTROL_TX_DISABLE_CHANNEL:
{
present = onlp_sfpi_is_present(port);
if(present == 1) {
if (port >= SFP_PORT_MIN && port <= SFP_PORT_MAX) { //SFP
if (onlp_file_write_int(value, MODULE_TXDISABLE_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to set tx_disable status to port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
rv = ONLP_STATUS_OK;
}
}
else if(port >= QSFP_PORT_MIN && port <= QSFP_PORT_MAX){ //QSFP
/* txdis valid bit(bit0-bit3), xxxx 1111 */
value = value & 0xf;
onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_TXDIS, value);

rv = ONLP_STATUS_OK;
}
}
else {
rv = ONLP_STATUS_E_INTERNAL;
}
break;
}

case ONLP_SFP_CONTROL_RESET:
{
VALIDATE_QSFP(port);
if (onlp_file_write_int(value, MODULE_RESET_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to write reset status to port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
rv = ONLP_STATUS_OK;
}
break;
}

case ONLP_SFP_CONTROL_LP_MODE:
{
if (onlp_file_write_int(value, MODULE_TXDISABLE_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to set tx_disable status to port(%d)\r\n", port);
VALIDATE_QSFP(port);
if (onlp_file_write_int(value, MODULE_LPMODE_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to write lpmode status to port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
Expand All @@ -356,18 +427,18 @@ int
onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
{
int rv;

if (port < 0 || port >= 48) {
return ONLP_STATUS_E_UNSUPPORTED;
}

int addr = (port < 38) ? 61 : 62;
int tx_dis_val = 0;
int present = 0;

VALIDATE_PORT(port);

switch(control)
{
case ONLP_SFP_CONTROL_RX_LOS:
{
if (onlp_file_read_int(value, MODULE_RXLOS_FORMAT, 3, addr, (port+1)) < 0) {
VALIDATE_SFP(port);
if (onlp_file_read_int(value, MODULE_RXLOS_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to read rx_loss status from port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -379,7 +450,8 @@ onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)

case ONLP_SFP_CONTROL_TX_FAULT:
{
if (onlp_file_read_int(value, MODULE_TXFAULT_FORMAT, 3, addr, (port+1)) < 0) {
VALIDATE_SFP(port);
if (onlp_file_read_int(value, MODULE_TXFAULT_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to read tx_fault status from port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -390,9 +462,51 @@ onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
}

case ONLP_SFP_CONTROL_TX_DISABLE:
case ONLP_SFP_CONTROL_TX_DISABLE_CHANNEL:
{
present = onlp_sfpi_is_present(port);
if(present == 1){
if (port >= SFP_PORT_MIN && port <= SFP_PORT_MAX) { //SFP
if (onlp_file_read_int(value, MODULE_TXDISABLE_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to read tx_disabled status from port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
rv = ONLP_STATUS_OK;
}
}
else if(port >= QSFP_PORT_MIN && port <= QSFP_PORT_MAX){ //QSFP
/* txdis valid bit(bit0-bit3), xxxx 1111 */
tx_dis_val = onlp_sfpi_dev_readb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_TXDIS);
*value = tx_dis_val;

rv = ONLP_STATUS_OK;
}
}
else {
rv = ONLP_STATUS_E_INTERNAL;
}
break;
}

case ONLP_SFP_CONTROL_RESET:
{
VALIDATE_QSFP(port);
if (onlp_file_read_int(value, MODULE_RESET_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to read reset status from port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
rv = ONLP_STATUS_OK;
}
break;
}

case ONLP_SFP_CONTROL_LP_MODE:
{
if (onlp_file_read_int(value, MODULE_TXDISABLE_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to read tx_disabled status from port(%d)\r\n", port);
VALIDATE_QSFP(port);
if (onlp_file_read_int(value, MODULE_LPMODE_FORMAT, 3, addr, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to read lpmode status from port(%d)\r\n", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
Expand Down