Add UDS socket test for yagp_hooks_collector#16
Merged
NJrslv merged 1 commit intoyagp-hooks-collectorfrom Jan 20, 2026
Merged
Conversation
The testing C functions have changed to set-returning ones if comparing with [1] because we need a control over the place where function is executed - either on master or segments. In cloudberry these functions must return set of values so I changed them to return SETOF. Similarly to [2], these functions were moved to hook_wrappers.cpp. The part of converting functions to set-returning ones was also done in commit [2]. [1] open-gpdb/gpdb@989ca06 [2] ae4079f
Author
|
The CI check is here https://github.com/open-gpdb/cloudberry/actions/runs/21174609806 |
NJrslv
added a commit
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to [1] add a test for UDS sockets in yagp_hooks_collector.
The testing C functions have changed to set-returning ones if comparing with [1] because we need a control over the place where function is executed - either on master or segments. In cloudberry these functions must return set of values so I changed them to return SETOF. Similarly to [2], these functions were moved to hook_wrappers.cpp.
The part of converting functions to set-returning ones was also done in commit [2].
[1] open-gpdb/gpdb@989ca06
[2] ae4079f