Skip to content

z-aware pointer#1671

Draft
Fil wants to merge 7 commits intomainfrom
fil/pointer-z
Draft

z-aware pointer#1671
Fil wants to merge 7 commits intomainfrom
fil/pointer-z

Conversation

@Fil
Copy link
Contributor

@Fil Fil commented Jun 6, 2023

Demo: https://observablehq.com/@observablehq/pointer-z-1671

Questions:

  • Do we always follow an explicit z? ✓
  • Do line marks (and area, etc.) set z when the stroke or fill option is specified? ✓
  • Is this something we want to opt-in more explicitely (e.g. zPointer: true)? NO

Done:

  • expose the series for viewof, not just one data point.
  • create the groups in an initializer
Enregistrement.de.l.ecran.2023-06-06.a.16.40.12.mov

closes #1574

maybe also part of a solution for #1621?

@Fil Fil requested a review from mbostock June 6, 2023 14:41
@Fil
Copy link
Contributor Author

Fil commented Jun 7, 2023

Note: in order to minimize the diff, I did not wrap the call to initializer(options, ƒ). To do before merging.

@Fil Fil marked this pull request as ready for review June 7, 2023 09:56
@Fil Fil force-pushed the fil/pointer-z branch from 5855f07 to b405dbd Compare June 27, 2023 11:07
@Fil
Copy link
Contributor Author

Fil commented Jun 27, 2023

rebased

@mootari
Copy link
Member

mootari commented Oct 22, 2023

It would be great to have this in Plot! 🙏🏻 What remaining issues need to be resolved?

@Fil
Copy link
Contributor Author

Fil commented Sep 28, 2024

@Fil Fil mentioned this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pointer, but that filters everything with a matching z value

2 participants

Comments